Skip to content

feat: #1 Outline lockup/wordmark text to paths - #4

Closed
patoperpetua wants to merge 1 commit into
mainfrom
feat/1-outline-and-cdn-cutover
Closed

feat: #1 Outline lockup/wordmark text to paths#4
patoperpetua wants to merge 1 commit into
mainfrom
feat/1-outline-and-cdn-cutover

Conversation

@patoperpetua

@patoperpetua patoperpetua commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Outline all lockup/wordmark <text> to SVG paths using Open Sauce Sans OTFs
  • Add pnpm outline:text + validate rule forbidding live <text> in wordmark sources
  • Commit OFL fonts under fonts/ for reproducible outlining

Companion marketing cutover: poc-inkads-marketing#95 (Pages CDN).

Test plan

Made with Cursor

@patoperpetua @cursoragent
feat: #1 Outline lockup and wordmark text to paths
364081e 
Convert Open Sauce Sans <text> to paths for deterministic PNG/email
rasterization; add outline:text tooling and reject live text in validate.

Co-authored-by: Cursor <cursoragent@cursor.com>
greptile-apps[bot]
greptile-apps Bot reviewed Sep 10, 2026
View reviewed changes

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patoperpetua has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 5 included reviews currently available. Your 16 included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 4e4eeb01-ba38-4746-a373-2a5771a849a0

📥 Commits

Reviewing files that changed from the base of the PR and between f45cea9 and 364081e.

⛔ Files ignored due to path filters (17)
  • fonts/OpenSauceSans-Medium.otf is excluded by !**/*.otf
  • fonts/OpenSauceSans-SemiBold.otf is excluded by !**/*.otf
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • src/logo/wordmark/sources/lockup-horizontal/dark.svg is excluded by !**/*.svg
  • src/logo/wordmark/sources/lockup-horizontal/light.svg is excluded by !**/*.svg
  • src/logo/wordmark/sources/lockup-horizontal/mono.svg is excluded by !**/*.svg
  • src/logo/wordmark/sources/lockup-stacked/dark.svg is excluded by !**/*.svg
  • src/logo/wordmark/sources/lockup-stacked/light.svg is excluded by !**/*.svg
  • src/logo/wordmark/sources/wordmark/dark.svg is excluded by !**/*.svg
  • src/logo/wordmark/sources/wordmark/light.svg is excluded by !**/*.svg
  • svg/lockup-horizontal/lockup-horizontal-dark.svg is excluded by !**/*.svg
  • svg/lockup-horizontal/lockup-horizontal-light.svg is excluded by !**/*.svg
  • svg/lockup-horizontal/lockup-horizontal-mono.svg is excluded by !**/*.svg
  • svg/lockup-stacked/lockup-stacked-dark.svg is excluded by !**/*.svg
  • svg/lockup-stacked/lockup-stacked-light.svg is excluded by !**/*.svg
  • svg/wordmark/wordmark-dark.svg is excluded by !**/*.svg
  • svg/wordmark/wordmark-light.svg is excluded by !**/*.svg
📒 Files selected for processing (7)
  • BRAND.md
  • docs/logo-asset-workflow.md
  • fonts/Open Sauce Sans OFL.txt
  • fonts/README.md
  • package.json
  • scripts/outline-text-svgs.mjs
  • scripts/validate-assets.mjs

Comment @coderabbitai help to get the list of available commands.

@patoperpetua

patoperpetua commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

Closing: the SVG diffs are text→path only (same look). Marketing consumes icon SVGs + CSS wordmark, not these lockups, so this change adds review noise without a consumer benefit right now.

Can reopen later if email/docs packs need font-independent lockup rasters.

@patoperpetua
patoperpetua deleted the feat/1-outline-and-cdn-cutover branch September 10, 2026 14:09
@patoperpetua patoperpetua mentioned this pull request Sep 10, 2026
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@patoperpetua